Improve docblocks #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmikola you wanna gives this a quick look? |
| @@ -45,7 +46,7 @@ public function getId() | |||
| } | |||
|
|
|||
| /** | |||
| * @see Cursor::getServer() | |||
There was a problem hiding this comment.
When implementing an interface or overriding a method, I do this instead of copy/pasting. It's up to you.
Some projects use @inheritDoc, but I've had mixed results with it and this is more explicit, as any generator should create a hyperlink to the referenced doc block.
There was a problem hiding this comment.
mmmh.
I'm using this data to create the extension skeleton. Not really keen on making a full fledged javadoc parser :)
derickr
added a commit
that referenced
this pull request
Nov 20, 2018
derickr
added a commit
that referenced
this pull request
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of docblock and linting fixes.